Fix WebAppAuthSettingsV2 deletion#4373
Merged
Merged
Conversation
Fixes #4330 This fixes the deletion of `azure-native:web:WebAppAuthSettingsV2` and `azure-native:web:WebAppAuthSettingsV2Slot` resources, which were failing with "Status=400 Message='The parameter properties has an invalid value.'" The Azure REST API does not support DELETE operations for these singleton child resources. Instead, they must be "reset" to their default state via a PUT operation. This fix adds both resources to `defaultResourcesState.go`, following the same pattern used to fix `WebAppAuthSettings` (V1) in PR #1160. When Pulumi destroys these resources, it now sends: ``` PUT .../config/authsettingsV2 { "platform": { "enabled": false } } ``` This resets the auth settings to their disabled state instead of attempting a DELETE, which the API rejects. Tested with `TestAccAppServiceTs` - the test now passes completely including the destroy operation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
approved these changes
Oct 23, 2025
guineveresaenger
left a comment
guineveresaenger
left a comment
Contributor
There was a problem hiding this comment.
This fixes the broken test for me locally.
Question:
Do we need to generate the SDKs before merging? Still getting familiar with the workflow here!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4373 +/- ##
==========================================
+ Coverage 59.79% 60.87% +1.08%
==========================================
Files 91 91
Lines 14243 11448 -2795
==========================================
- Hits 8516 6969 -1547
+ Misses 5064 3815 -1249
- Partials 663 664 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The workaround added in PR #4349 is no longer needed now that the proper provider-level fix is in place via defaultResourcesState.go. The test passes successfully without this workaround. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Regenerate SDKs to pick up WebAppAuthSettingsV2 changes and new WithoutSecrets resources. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add GITHUB_TOKEN to the workflow-level environment variables section to make it available globally across all jobs and steps that interact with the GitHub API, preventing rate limiting issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This PR has been shipped in release v3.10.0. |
3 similar comments
Contributor
|
This PR has been shipped in release v3.10.0. |
Contributor
|
This PR has been shipped in release v3.10.0. |
Contributor
|
This PR has been shipped in release v3.10.0. |
EronWright
added a commit
that referenced
this pull request
Nov 26, 2025
Adds WebAppAuthSettingsV2 and WebAppAuthSettingsV2Slot to defaultResourcesState.go so the provider resets auth settings via PUT instead of attempting DELETE. Removes the platform property workaround from the example since the provider now handles deletion correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Nov 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4330
This PR fixes the deletion of
azure-native:web:WebAppAuthSettingsV2andazure-native:web:WebAppAuthSettingsV2Slotresources, which were failing with:Root Cause
The Azure REST API does not support DELETE operations for these singleton child resources (the spec shows
delete: null). Instead, they must be "reset" to their default state via a PUT operation.Solution
Added both resources to
provider/pkg/openapi/defaults/defaultResourcesState.go, following the same pattern used to fixWebAppAuthSettings(V1) in PR #1160.When Pulumi destroys these resources, it now sends:
This resets the auth settings to their disabled state instead of attempting a DELETE.
Testing
✅ Verified with
TestAccAppServiceTs- the test now passes completely including the destroy operation that was previously failing.Changes
WebAppAuthSettingsV2(main site)WebAppAuthSettingsV2Slot(slot configuration)🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com